fix(wrangler): fix spurious config diffs for binding arrays in different order#12135
Merged
edmundhung merged 2 commits intomainfrom Feb 11, 2026
Merged
fix(wrangler): fix spurious config diffs for binding arrays in different order#12135edmundhung merged 2 commits intomainfrom
edmundhung merged 2 commits intomainfrom
Conversation
🦋 Changeset detectedLatest commit: 10954a1 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
create-cloudflare
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-editor-shared
@cloudflare/workers-utils
wrangler
commit: |
edmundhung
force-pushed
the
edmundhung/fix-config-diff-binding-order
branch
from
a63c605 to
b874b2d
Compare
Contributor
|
Claude finished @edmundhung's task —— View job Changeset Review✅ All changesets look good The changeset
|
edmundhung
force-pushed
the
edmundhung/fix-config-diff-binding-order
branch
from
b874b2d to
c74aeb0
Compare
edmundhung
force-pushed
the
edmundhung/fix-config-diff-binding-order
branch
from
c74aeb0 to
ef991bf
Compare
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
dario-piotrowicz
approved these changes
Feb 11, 2026
Member
dario-piotrowicz
left a comment
dario-piotrowicz
left a comment
There was a problem hiding this comment.
Looks great to me! Thanks @edmundhung! 🫶 😄
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #12074.
The config diff handles object keys in different order just fine, the root issue here is arrays being compared positionally. So if the remote API returns
kv_namespaceswith the same bindings in a different order, the diff shows them as removed and re-added.This sorts remote binding arrays to match the local config's order before comparing. The list of binding types is type-checked exhaustively against
CfWorkerInit["bindings"], so new binding types will cause a compile error if not handled.A picture of a cute animal (not mandatory, but encouraged)